pgsql: pg_dump: Fix inconsistent sscanf() conversions

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: pg_dump: Fix inconsistent sscanf() conversions
Date: 2016-02-19 01:33:42
Message-ID: E1aWZx0-0003lI-Sq@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

pg_dump: Fix inconsistent sscanf() conversions

It was using %u to read a string that was earlier produced by snprintf with %d
into a signed integer variable. This seems to work in practice but is
incorrect.

found by cppcheck

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/a914a0414232e30943f7b2ffd997d74bd018a7b1

Modified Files
--------------
src/bin/pg_dump/pg_backup_custom.c | 2 +-
src/bin/pg_dump/pg_backup_directory.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Simon Riggs 2016-02-19 08:35:47 pgsql: Correct StartupSUBTRANS for page wraparound
Previous Message Tom Lane 2016-02-19 01:02:22 pgsql: Add an explicit representation of the output targetlist to Paths