pgsql: Fix unobvious interaction between -X switch and subdirectory cre

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Fix unobvious interaction between -X switch and subdirectory cre
Date: 2016-01-07 23:21:20
Message-ID: E1aHJrs-0004bx-L9@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix unobvious interaction between -X switch and subdirectory creation.

Turns out the only reason initdb -X worked is that pg_mkdir_p won't
whine if you point it at something that's a symlink to a directory.
Otherwise, the attempt to create pg_xlog/ just like all the other
subdirectories would have failed. Let's be a little more explicit
about what's happening. Oversight in my patch for bug #13853
(mea culpa for not testing -X ...)

Branch
------
REL9_5_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/506ef1d07f8b51e9799f6856b03a4317297a39cb

Modified Files
--------------
src/bin/initdb/initdb.c | 37 ++++++++++++++++++++++++-------------
1 file changed, 24 insertions(+), 13 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Alvaro Herrera 2016-01-07 23:35:05 pgsql: Fix order of arguments to va_start()
Previous Message Tom Lane 2016-01-07 22:36:49 pgsql: Fix one more TAP test to use standard command-line argument orde