pgsql: Don't zero opfuncid when reading nodes.

From: Robert Haas <rhaas(at)postgresql(dot)org>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Don't zero opfuncid when reading nodes.
Date: 2015-09-24 15:37:07
Message-ID: E1Zf8a3-0003WW-8h@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Don't zero opfuncid when reading nodes.

The comments here stated that this was just in case we ever had an
ALTER OPERATOR command that could remap an operator to a different
function. But those comments have been here for a long time, and no
such command has come about. In the absence of such a feature,
forcing the pg_proc OID to be looked up again each time we reread a
stored rule or similar is just a waste of cycles. Moreover, parallel
query needs a way to reread the exact same node tree that was written
out, not one that has been slightly stomped on. So just get rid of
this for now.

Per discussion with Tom Lane.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/9f1255ac859364a86264a67729dbd1a36dd63ff2

Modified Files
--------------
src/backend/nodes/readfuncs.c | 44 -----------------------------------------
1 file changed, 44 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Alvaro Herrera 2015-09-24 15:39:54 Re: [COMMITTERS] pgsql: Lower *_freeze_max_age minimum values.
Previous Message Andres Freund 2015-09-24 14:46:40 Re: pgsql: Lower *_freeze_max_age minimum values.