pgsql: Improve log messages related to tablespace_map file

From: Fujii Masao <fujii(at)postgresql(dot)org>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Improve log messages related to tablespace_map file
Date: 2015-09-15 14:23:46
Message-ID: E1Zbr98-0007Rr-14@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Improve log messages related to tablespace_map file

This patch changes the log message which is logged when the server
successfully renames backup_label file to *.old but fails to rename
tablespace_map file during the shutdown. Previously the WARNING
message "online backup mode was not canceled" was logged in that case.
However this message is confusing because the backup mode is treated
as canceled whenever backup_label is successfully renamed. So this
commit makes the server log the message "online backup mode canceled"
in that case.

Also this commit changes errdetail messages so that they follow the
error message style guide.

Back-patch to 9.5 where tablespace_map file is introduced.

Original patch by Amit Kapila, heavily modified by me.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/10fbb79f1a918124f39fc8a87b8d19db3712202f

Modified Files
--------------
src/backend/access/transam/xlog.c | 36 ++++++++++++++++++++----------------
1 file changed, 20 insertions(+), 16 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Fujii Masao 2015-09-15 14:24:14 Re: Re: [COMMITTERS] pgsql: Map basebackup tablespaces using a tablespace_map file
Previous Message Tom Lane 2015-09-15 13:51:48 Re: [COMMITTERS] pgsql: Fix an O(N^2) problem in foreign key references.