pgsql: Fix potential platform dependence in gist regression test.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Fix potential platform dependence in gist regression test.
Date: 2015-08-25 15:43:46
Message-ID: E1ZUGO2-0007H6-DM@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix potential platform dependence in gist regression test.

The results of the KNN-search test cases were indeterminate, as they asked
the system to sort pairs of points that are exactly equidistant from the
query reference point. It's a bit surprising that we've seen no
platform-specific failures from this in the buildfarm. Perhaps IEEE-float
math is well enough standardized that no such failures will ever occur on
supported platforms ... but since this entire regression test has yet to be
shipped in any non-alpha release, that seems like an unduly optimistic
assumption. Tweak the queries so that the correct output is uniquely
defined.

(The other queries in this test are also underdetermined; but it looks like
they are regurgitating index rows in insertion order, so for the moment
assume that that behavior is stable enough.)

Per Greg Stark's experiments with VAX. Back-patch to 9.5 where this test
script was introduced.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/e39c4afcfa0fb2c708e49e54089118d9b4ba5f89

Modified Files
--------------
src/test/regress/expected/gist.out | 16 ++++++++--------
src/test/regress/sql/gist.sql | 8 ++++----
2 files changed, 12 insertions(+), 12 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2015-08-25 17:09:54 pgsql: Limit the verbosity of memory context statistics dumps.
Previous Message Peter Eisentraut 2015-08-25 14:02:23 Re: [COMMITTERS] pgsql: Change TAP test framework to not rely on having a chmod executab