pgsql: Avoid use of float arithmetic in bipartite_match.c.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Avoid use of float arithmetic in bipartite_match.c.
Date: 2015-08-23 17:02:35
Message-ID: E1ZTYfD-0005B0-4M@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Avoid use of float arithmetic in bipartite_match.c.

Since the distances used in this algorithm are small integers (not more
than the size of the U set, in fact), there is no good reason to use float
arithmetic for them. Use short ints instead: they're smaller, faster, and
require no special portability assumptions.

Per testing by Greg Stark, which disclosed that the code got into an
infinite loop on VAX for lack of IEEE-style float infinities. We don't
really care all that much whether Postgres can run on a VAX anymore,
but there seems sufficient reason to change this code anyway.

In passing, make a few other small adjustments to make the code match
usual Postgres coding style a bit better.

Branch
------
REL9_5_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/4022f94c350f96fc5feff0503d3e2f2f6f9086cc

Modified Files
--------------
src/backend/lib/bipartite_match.c | 75 +++++++++++++++++++++++--------------
src/include/lib/bipartite_match.h | 16 ++++----
2 files changed, 55 insertions(+), 36 deletions(-)

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Andres Freund 2015-08-23 17:25:46 Re: pgsql: Avoid use of float arithmetic in bipartite_match.c.
Previous Message Kevin Grittner 2015-08-23 16:41:10 pgsql: Fix typo in C comment.