pgsql: Restore use of zlib default compression in pg_dump directory mod

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Restore use of zlib default compression in pg_dump directory mod
Date: 2015-07-25 21:17:59
Message-ID: E1ZJ6pT-0004V3-5p@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Restore use of zlib default compression in pg_dump directory mode.

This was broken by commit 0e7e355f27302b62af3e1add93853ccd45678443 and
friends, which ignored the fact that gzopen() will treat "-1" in the
mode argument as an invalid character, which it ignores, and a flag for
compression level 1. Now, when this value is encountered no compression
level flag is passed to gzopen, leaving it to use the zlib default.

Also, enforce the documented allowed range for pg_dump's -Z option,
namely 0 .. 9, and remove some consequently dead code from
pg_backup_tar.c.

Problem reported by Marc Mamin.

Backpatch to 9.1, like the patch that introduced the bug.

Branch
------
REL9_4_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/41ed5bb9aeddddbe8f8afb901567fd5f306d2a45

Modified Files
--------------
src/bin/pg_dump/compress_io.c | 18 ++++++++++++++----
src/bin/pg_dump/pg_backup_tar.c | 7 -------
src/bin/pg_dump/pg_dump.c | 5 +++++
3 files changed, 19 insertions(+), 11 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2015-07-25 21:19:16 Re: pgsql: Replace our hacked version of ax_pthread.m4 with latest upstream
Previous Message Tom Lane 2015-07-25 20:37:31 pgsql: Some platforms now need contrib/tsm_system_time to be linked wit