pgsql: Fix omission of OCLASS_TRANSFORM in object_classes[]

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Fix omission of OCLASS_TRANSFORM in object_classes[]
Date: 2015-07-21 11:21:26
Message-ID: E1ZHVby-0002uc-0Z@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix omission of OCLASS_TRANSFORM in object_classes[]

This was forgotten in cac76582053e (and its fixup ad89a5d115). Since it
seems way too easy to miss this, this commit also introduces a mechanism
to enforce that the array is consistent with the enum.

Problem reported independently by Robert Haas and Jaimin Pan.
Patches proposed by Jaimin Pan, Jim Nasby, Michael Paquier and myself,
though I didn't use any of these and instead went with a cleaner
approach suggested by Tom Lane.

Backpatch to 9.5.

Discussion:
https://www.postgresql.org/message-id/CA+Tgmoa6SgDaxW_n_7SEhwBAc=mniYga+obUj5fmw4rU9_mLvA@mail.gmail.com
https://www.postgresql.org/message-id/29788.1437411581@sss.pgh.pa.us

Branch
------
REL9_5_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/d6ec181cf14a1d3f3d8ca9400a404b9828776ca3

Modified Files
--------------
src/backend/catalog/dependency.c | 11 +++++++++--
src/backend/commands/event_trigger.c | 9 ---------
src/include/catalog/dependency.h | 7 ++++---
3 files changed, 13 insertions(+), 14 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2015-07-21 12:58:24 Re: pgsql: vacuumlo: Avoid unlikely memory leak.
Previous Message Emre Hasegeli 2015-07-21 09:59:50 Re: [COMMITTERS] pgsql: Improve BRIN documentation somewhat