| From: | Noah Misch <noah(at)leadboat(dot)com> |
|---|---|
| To: | pgsql-committers(at)postgresql(dot)org |
| Subject: | pgsql: Truncate strings in tarCreateHeader() with strlcpy(), not sprint |
| Date: | 2015-06-22 00:14:35 |
| Message-ID: | E1Z6pNj-00060r-Oa@gemulon.postgresql.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Truncate strings in tarCreateHeader() with strlcpy(), not sprintf().
This supplements the GNU libc bug #6530 workarounds introduced in commit
54cd4f04576833abc394e131288bf3dd7dcf4806. On affected systems, a
tar-format pg_basebackup failed when some filename beneath the data
directory was not valid character data in the postmaster/walsender
locale. Back-patch to 9.1, where pg_basebackup was introduced. Extant,
bug-prone conversion specifications receive only ASCII bytes or involve
low-importance messages.
Branch
------
master
Details
-------
http://git.postgresql.org/pg/commitdiff/4318118edd5582696027f357771e0a8b091fe2bf
Modified Files
--------------
src/bin/pg_basebackup/t/010_pg_basebackup.pl | 8 ++++++++
src/port/tar.c | 8 ++++----
2 files changed, 12 insertions(+), 4 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2015-06-22 18:15:58 | pgsql: psql: Add some tab completion for TABLESAMPLE. |
| Previous Message | Alvaro Herrera | 2015-06-21 19:23:53 | pgsql: Add transforms to pg_get_object_address and friends |