pgsql: Fix failure to copy IndexScan.indexorderbyops in copyfuncs.c.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Fix failure to copy IndexScan.indexorderbyops in copyfuncs.c.
Date: 2015-05-18 01:22:18
Message-ID: E1Yu9l4-0002Nh-40@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix failure to copy IndexScan.indexorderbyops in copyfuncs.c.

This oversight results in a crash at executor startup if the plan has
been copied. outfuncs.c was missed as well.

While we could probably have taught both those files to cope with the
originally chosen representation of an Oid array, it would have been
painful, not least because there'd be no easy way to verify the array
length. An Oid List is far easier to work with. And AFAICS, there is
no particular notational benefit to using an array rather than a list
in the existing parts of the patch either. So just change it to a list.

Error in commit 35fcb1b3d038a501f3f4c87c05630095abaaadab, which is new,
so no need for back-patch.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/424661913c06af76a46fdff9cc24cc57abf14fb3

Modified Files
--------------
src/backend/executor/nodeIndexscan.c | 20 ++++++++++-------
src/backend/nodes/copyfuncs.c | 1 +
src/backend/nodes/outfuncs.c | 1 +
src/backend/optimizer/plan/createplan.c | 37 ++++++++++++++-----------------
src/include/nodes/plannodes.h | 11 +++++----
5 files changed, 36 insertions(+), 34 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2015-05-18 01:44:27 Re: pgsql: Recursively fsync() the data directory after a crash.
Previous Message Tom Lane 2015-05-18 00:04:48 pgsql: Use += not = to set makefile variables after including base make