pgsql: Make the pg_rewind regression tests more robust on slow systems.

From: Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Make the pg_rewind regression tests more robust on slow systems.
Date: 2015-04-22 11:37:55
Message-ID: E1YksyZ-00078I-D2@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Make the pg_rewind regression tests more robust on slow systems.

There were a couple of hard-coded sleeps in the tests: to wait for standby
to catch up with master, and to wait for promotion with "pg_ctl promote"
to complete. Instead of a fixed, hard-coded sleep, poll the server with a
query once a second. This isn't ideal either, and I wish we had a better
solution for real-world applications too, but this should fix the
immediate problem.

Patch by Michael Paquier, with some editing by me.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/54a16df0100da445be7c79eb81dfb96fd0685e6d

Modified Files
--------------
src/bin/pg_rewind/RewindTest.pm | 46 ++++++++++++++++++++++++++++++++++-----
1 file changed, 41 insertions(+), 5 deletions(-)

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Stephen Frost 2015-04-22 15:29:43 pgsql: Pull in tableoid for inheiritance with rowMarks
Previous Message Andres Freund 2015-04-22 07:44:35 pgsql: Rename pg_replication_slot's new active_in to active_pid.