|From:||Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>|
|Subject:||pgsql: Further tweaking of raw grammar output to distinguish different|
|Views:||Raw Message | Whole Thread | Download mbox | Resend email|
Further tweaking of raw grammar output to distinguish different inputs.
Use a different A_Expr_Kind for LIKE/ILIKE/SIMILAR TO constructs, so that
they can be distinguished from direct invocation of the underlying
operators. Also, postpone selection of the operator name when transforming
"x IN (select)" to "x = ANY (select)", so that those syntaxes can be told
apart at parse analysis time.
I had originally thought I'd also have to do something special for the
syntaxes IS NOT DISTINCT FROM, IS NOT DOCUMENT, and x NOT IN (SELECT...),
which the grammar translates as though they were NOT (construct).
On reflection though, we can distinguish those cases reliably by noting
whether the parse location shown for the NOT is the same as for its child
node. This only requires tweaking the parse locations for NOT IN, which
I've done here.
These changes should have no effect outside the parser; they're just in
support of being able to give accurate warnings for planned operator
src/backend/nodes/outfuncs.c | 12 +++++++++
src/backend/parser/gram.y | 52 +++++++++++++++++++++++++++------------
src/backend/parser/parse_expr.c | 12 +++++++++
src/include/nodes/parsenodes.h | 3 +++
src/include/nodes/primnodes.h | 1 -
5 files changed, 63 insertions(+), 17 deletions(-)
|Next Message||Alvaro Herrera||2015-02-23 18:05:47||pgsql: Fix stupid merge errors in previous commit|
|Previous Message||Alvaro Herrera||2015-02-23 17:23:10||pgsql: Support more commands in event triggers|