pgsql: pg_standby: Avoid writing one byte beyond the end of the buffer.

From: Robert Haas <rhaas(at)postgresql(dot)org>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: pg_standby: Avoid writing one byte beyond the end of the buffer.
Date: 2015-01-15 14:46:57
Message-ID: E1YBlhJ-0005Bf-Dz@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

pg_standby: Avoid writing one byte beyond the end of the buffer.

Previously, read() might have returned a length equal to the buffer
length, and then the subsequent store to buf[len] would write a
zero-byte one byte past the end. This doesn't seem likely to be
a security issue, but there's some chance it could result in
pg_standby misbehaving.

Spotted by Coverity; patch by Michael Paquier, reviewed by me.

Branch
------
REL9_1_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/151fb75b0d6eb1e9622ef53e11361986ea26bae5

Modified Files
--------------
contrib/pg_standby/pg_standby.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2015-01-15 18:18:32 pgsql: Improve performance of EXPLAIN with large range tables.
Previous Message Andres Freund 2015-01-15 12:31:06 pgsql: Blindly try to fix a warning in s_lock.h when compiling with gcc