pgsql: Remove dead code supporting mark/restore in SeqScan, TidScan, Va

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Remove dead code supporting mark/restore in SeqScan, TidScan, Va
Date: 2014-11-21 01:21:00
Message-ID: E1XrcuC-0007PN-81@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Remove dead code supporting mark/restore in SeqScan, TidScan, ValuesScan.

There seems no prospect that any of this will ever be useful, and indeed
it's questionable whether some of it would work if it ever got called;
it's certainly not been exercised in a very long time, if ever. So let's
get rid of it, and make the comments about mark/restore in execAmi.c less
wishy-washy.

The mark/restore support for Result nodes is also currently dead code,
but that's due to planner limitations not because it's impossible that
it could be useful. So I left it in.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/adbfab119b308a7e0e6b1305de9be222cfd5c85b

Modified Files
--------------
src/backend/access/heap/heapam.c | 70 ---------------------------------
src/backend/executor/execAmi.c | 49 ++++++-----------------
src/backend/executor/nodeSeqscan.c | 38 ------------------
src/backend/executor/nodeTidscan.c | 30 --------------
src/backend/executor/nodeValuesscan.c | 25 ------------
src/include/access/heapam.h | 3 --
src/include/access/relscan.h | 2 -
src/include/executor/nodeSeqscan.h | 2 -
src/include/executor/nodeTidscan.h | 2 -
src/include/executor/nodeValuesscan.h | 2 -
src/include/nodes/execnodes.h | 3 --
11 files changed, 13 insertions(+), 213 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Heikki Linnakangas 2014-11-21 09:59:07 pgsql: Add pageinspect functions for inspecting GIN indexes.
Previous Message Tom Lane 2014-11-20 23:36:13 pgsql: Initial code review for CustomScan patch.