pgsql: Don't require bleeding-edge timezone data in timestamptz regress

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Don't require bleeding-edge timezone data in timestamptz regress
Date: 2014-11-19 02:37:19
Message-ID: E1Xqv8x-0005HB-9W@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Don't require bleeding-edge timezone data in timestamptz regression test.

The regression test cases added in commits b2cbced9e et al depended in part
on the Russian timezone offset changes of Oct 2014. While this is of no
particular concern for a default Postgres build, it was possible for a
build using --with-system-tzdata to fail the tests if the system tzdata
database wasn't au courant. Bjorn Munch and Christoph Berg both complained
about this while packaging 9.4rc1, so we probably shouldn't insist on the
system tzdata being up-to-date. Instead, make an equivalent test using a
zone change that occurred in Venezuela in 2007. With this patch, the
regression tests should pass using any tzdata set from 2012 or later.
(I can't muster much sympathy for somebody using --with-system-tzdata
on a machine whose system tzdata is more than three years out-of-date.)

Branch
------
REL9_0_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/e1f91066fd4d718161eb9cb9bacaa706273a4ba1

Modified Files
--------------
src/test/regress/expected/timestamptz.out | 216 +++++++++++++++--------------
src/test/regress/sql/timestamptz.sql | 115 +++++++--------
2 files changed, 168 insertions(+), 163 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Fujii Masao 2014-11-19 05:12:15 pgsql: Fix pg_receivexlog --slot so that it doesn't prevent the server
Previous Message Tom Lane 2014-11-18 20:51:52 pgsql: Update comments in find_typedef.