pgsql: Fix bogus return macros in range_overright_internal().

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Fix bogus return macros in range_overright_internal().
Date: 2014-08-16 17:49:10
Message-ID: E1XIi6I-00078z-Fs@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix bogus return macros in range_overright_internal().

PG_RETURN_BOOL() should only be used in functions following the V1 SQL
function API. This coding accidentally fails to fail since letting the
compiler coerce the Datum representation of bool back to plain bool
does give the right answer; but that doesn't make it a good idea.

Back-patch to older branches just to avoid unnecessary code divergence.

Branch
------
REL9_3_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/f2d4f45c0ec7073dba75ffec8402b6d61de3bcfc

Modified Files
--------------
src/backend/utils/adt/rangetypes.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Noah Misch 2014-08-17 06:57:46 Re: pgsql: Cosmetic improvements in plpython's make rule for libpython impo
Previous Message Tom Lane 2014-08-16 17:22:56 pgsql: Add opr_sanity queries to inspect commutator/negator links more