pgsql: Get rid of bogus separate pg_proc entries for json_extract_path

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Get rid of bogus separate pg_proc entries for json_extract_path
Date: 2014-06-26 23:22:29
Message-ID: E1X0Izt-0006CF-ER@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Get rid of bogus separate pg_proc entries for json_extract_path operators.

These should not have existed to begin with, but there was apparently some
misunderstanding of the purpose of the opr_sanity regression test item
that checks for operator implementation functions with their own comments.
The idea there is to check for unintentional violations of the rule that
operator implementation functions shouldn't be documented separately
.... but for these functions, that is in fact what we want, since the
variadic option is useful and not accessible via the operator syntax.
Get rid of the extra pg_proc entries and fix the regression test and
documentation to be explicit about what we're doing here.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/f71136eeeb5c6a234e19a245db7ae1484fc7bf4f

Modified Files
--------------
doc/src/sgml/func.sgml | 6 ++++--
src/include/catalog/catversion.h | 2 +-
src/include/catalog/pg_operator.h | 8 ++++----
src/include/catalog/pg_proc.h | 4 ----
src/test/regress/expected/opr_sanity.out | 20 ++++++++++++--------
5 files changed, 21 insertions(+), 19 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2014-06-27 18:09:06 pgsql: Disallow pushing volatile qual expressions down into DISTINCT su
Previous Message Tom Lane 2014-06-26 17:42:20 pgsql: Back-patch "Fix EquivalenceClass processing for nested append re