pgsql: Allow total number of transactions in pgbench to exceed INT_MAX.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Allow total number of transactions in pgbench to exceed INT_MAX.
Date: 2014-05-25 20:34:22
Message-ID: E1Wof7e-0006m3-Mc@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Allow total number of transactions in pgbench to exceed INT_MAX.

Change the total-transactions counters from int32 to int64 to accommodate
cases where we do more than 2^31 transactions during a run. This patch
does not change the INT_MAX limit on explicit "-t" parameters, but it
does allow the product of the -t and -c parameters to exceed INT_MAX, or
allow a -T limit that is large enough that more than 2^31 transactions
can be completed. While pgbench did not actually fail in such cases,
it did print an incorrect total-transactions count, and some of the
derived numbers such as TPS would have been wrong as well.

Tomas Vondra

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/9a65fb350717360c505de9df411024d47e55710b

Modified Files
--------------
contrib/pgbench/pgbench.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Heikki Linnakangas 2014-05-25 22:18:48 pgsql: Fix error when trying to delete page with half-dead left sibling
Previous Message Andres Freund 2014-05-25 15:57:27 pgsql: Don't allocate memory inside an Assert() iff in a critical secti