pgsql: Silence a couple of spurious valgrind warnings in inval.c.

From: Andres Freund <andres(at)anarazel(dot)de>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Silence a couple of spurious valgrind warnings in inval.c.
Date: 2014-05-24 17:11:35
Message-ID: E1WoFTr-0006ap-UF@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Silence a couple of spurious valgrind warnings in inval.c.

Define padding bytes in SharedInvalidationMessage structs to be
defined. Otherwise the sinvaladt.c ringbuffer, which is accessed by
multiple processes, will cause spurious valgrind warnings about
undefined memory being used. That's because valgrind remembers the
undefined bytes from the last local process's store, not realizing
that another process has written since, filling the previously
uninitialized bytes.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/0564bbe7a1690f025f4424d5a12cb6af9d428c48

Modified Files
--------------
src/backend/utils/cache/inval.c | 27 +++++++++++++++++++++++++++
1 file changed, 27 insertions(+)

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2014-05-24 21:10:57 Re: pgsql: Silence a couple of spurious valgrind warnings in inval.c.
Previous Message Bruce Momjian 2014-05-23 19:05:35 pgsql: doc: link/caps fixes for 9.4 release notes