From: | Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi> |
---|---|
To: | pgsql-committers(at)postgresql(dot)org |
Subject: | pgsql: Fix alignment of GIN in-line posting lists stored in entry tuple |
Date: | 2014-01-23 21:03:22 |
Message-ID: | E1W6RQo-0000Rf-BF@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Fix alignment of GIN in-line posting lists stored in entry tuples.
The Sparc machines in the buildfarm are crashing because of misaligned
access to posting lists stored in entry tuples.
I accidentally removed a critical SHORTALIGN() from ginFormTuple, as part
of the packed posting lists patch. Perhaps I thought it was unnecessary,
because the index_form_tuple() call above the SHORTALIGN already aligned
the size, missing the fact that the null-category byte makes it misaligned
again (I think the SHORTALIGN is indeed unnecessary if there's no null-
category byte, but let's just play it safe...)
Branch
------
master
Details
-------
http://git.postgresql.org/pg/commitdiff/ec8f692c3cd5760435712b7ec4afa8f014ed7b2e
Modified Files
--------------
src/backend/access/gin/ginentrypage.c | 2 ++
1 file changed, 2 insertions(+)
From | Date | Subject | |
---|---|---|---|
Next Message | Heikki Linnakangas | 2014-01-23 21:04:43 | Re: Re: [COMMITTERS] pgsql: Compress GIN posting lists, for smaller index size. |
Previous Message | Tom Lane | 2014-01-23 20:37:05 | Re: Re: [COMMITTERS] pgsql: Compress GIN posting lists, for smaller index size. |