|From:||Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>|
|Subject:||pgsql: Use SA_RESTART for all signals, including SIGALRM.|
|Views:||Raw Message | Whole Thread | Download mbox | Resend email|
Use SA_RESTART for all signals, including SIGALRM.
The exclusion of SIGALRM dates back to Berkeley days, when Postgres used
SIGALRM in only one very short stretch of code. Nowadays, allowing it to
interrupt kernel calls doesn't seem like a very good idea, since its use
for statement_timeout means SIGALRM could occur anyplace in the code, and
there are far too many call sites where we aren't prepared to deal with
EINTR failures. When third-party code is taken into consideration, it
seems impossible that we ever could be fully EINTR-proof, so better to
use SA_RESTART always and deal with the implications of that. One such
implication is that we should not assume pg_usleep() will be terminated
early by a signal. Therefore, long sleeps should probably be replaced
by WaitLatch operations where practical.
Back-patch to 9.3 so we can get some beta testing on this change.
src/backend/port/sysv_sema.c | 4 ++--
src/port/pqsignal.c | 4 +---
2 files changed, 3 insertions(+), 5 deletions(-)
|Next Message||Tom Lane||2013-06-15 19:40:18||pgsql: Use SA_RESTART for all signals, including SIGALRM.|
|Previous Message||Tom Lane||2013-06-15 18:11:57||pgsql: Be consistent about #define'ing configure symbols as "1" not emp|