pgsql: Ignore invalid indexes in pg_dump.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Ignore invalid indexes in pg_dump.
Date: 2013-03-26 21:43:54
Message-ID: E1UKbes-000189-Jw@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-committers pgsql-hackers

Ignore invalid indexes in pg_dump.

Dumping invalid indexes can cause problems at restore time, for example
if the reason the index creation failed was because it tried to enforce
a uniqueness condition not satisfied by the table's data. Also, if the
index creation is in fact still in progress, it seems reasonable to
consider it to be an uncommitted DDL change, which pg_dump wouldn't be
expected to dump anyway.

Back-patch to all active versions, and teach them to ignore invalid
indexes in servers back to 8.2, where the concept was introduced.

Michael Paquier

Branch
------
REL9_0_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/f4428cc21ddab3761a090a4f4d82bd6aa6e5d82f

Modified Files
--------------
src/bin/pg_dump/pg_dump.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Kevin Grittner 2013-03-26 21:46:11 Re: Drastic performance loss in assert-enabled build in HEAD
Previous Message Tom Lane 2013-03-26 21:18:42 Re: spoonbill vs. -HEAD

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2013-03-26 21:52:09 pgsql: Fix grammatical errors in some new message strings.
Previous Message Andres Freund 2013-03-26 20:20:19 Re: [COMMITTERS] pgsql: Add PF_PRINTF_ATTRIBUTE to on_exit_msg_fmt.