pgsql: Fill tuple before HeapSatisfiesHOTAndKeyUpdate

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Fill tuple before HeapSatisfiesHOTAndKeyUpdate
Date: 2013-02-01 13:50:02
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-committers

Fill tuple before HeapSatisfiesHOTAndKeyUpdate

Failing to do this results in almost all updates to system catalogs
being non-HOT updates, because the OID column would differ (not having
been set for the new tuple), which is an indexed column.

While at it, make sure to set the tableoid early in both old and new
tuples as well. This isn't of much consequence, since that column is
seldom (never?) indexed.

Report and patch from Andres Freund.



Modified Files
src/backend/access/heap/heapam.c | 39 +++++++++++++++++++++++--------------
1 files changed, 24 insertions(+), 15 deletions(-)


Browse pgsql-committers by date

  From Date Subject
Next Message Alvaro Herrera 2013-02-01 15:14:11 pgsql: Fix typo in freeze_table_age implementation
Previous Message Peter Eisentraut 2013-02-01 03:33:05 pgsql: Add CREATE RECURSIVE VIEW syntax