pgsql: Prevent creation of postmaster's TCP socket during pg_upgrade te

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Prevent creation of postmaster's TCP socket during pg_upgrade te
Date: 2013-01-03 23:35:11
Message-ID: E1TquJb-00071u-KM@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Prevent creation of postmaster's TCP socket during pg_upgrade testing.

On non-Windows machines, we use the Unix socket for connections to test
postmasters, so there is no need to create a TCP socket. Furthermore,
doing so causes failures due to port conflicts if two builds are carried
out concurrently on one machine. (If the builds are done in different
chroots, which is standard practice at least in Red Hat distros, there
is no risk of conflict on the Unix socket.) Suppressing the TCP socket
by setting listen_addresses to empty has long been standard practice
for pg_regress, and pg_upgrade knows about this too ... but pg_upgrade's
test.sh didn't get the memo.

Back-patch to 9.2, and also sync the 9.2 version of the script with HEAD
as much as practical.

Branch
------
REL9_2_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/48e0b8a23e3c6e095333a6d489d3f7771d28d383

Modified Files
--------------
contrib/pg_upgrade/test.sh | 17 +++++++++++++++--
1 files changed, 15 insertions(+), 2 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2013-01-04 22:42:42 pgsql: Invent a "one-shot" variant of CachedPlans for better performanc
Previous Message Heikki Linnakangas 2013-01-03 18:01:41 pgsql: Tolerate timeline switches while "pg_basebackup -X fetch" is run