pgsql: Fix SELECT DISTINCT with index-optimized MIN/MAX oninheritance

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Fix SELECT DISTINCT with index-optimized MIN/MAX oninheritance
Date: 2012-11-26 17:58:32
Message-ID: E1Td2wy-0002Q6-HM@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-committers

Fix SELECT DISTINCT with index-optimized MIN/MAX on inheritance trees.

In a query such as "SELECT DISTINCT min(x) FROM tab", the DISTINCT is
pretty useless (there being only one output row), but nonetheless it
shouldn't fail. But it could fail if "tab" is an inheritance parent,
because planagg.c's code for fixing up equivalence classes after making the
index-optimized MIN/MAX transformation wasn't prepared to find child-table
versions of the aggregate expression. The least ugly fix seems to be
to add an option to mutate_eclass_expressions() to skip child-table
equivalence class members, which aren't used anymore at this stage of
planning so it's not really necessary to fix them. Since child members
are ignored in many cases already, it seems plausible for
mutate_eclass_expressions() to have an option to ignore them too.

Per bug #7703 from Maxim Boguk.

Back-patch to 9.1. Although the same code exists before that, it cannot
encounter child-table aggregates AFAICS, because the index optimization
transformation cannot succeed on inheritance trees before 9.1 (for lack
of MergeAppend).

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/d3237e04ca380d6c08f6133fde97a9d956e3161a

Modified Files
--------------
src/backend/optimizer/path/equivclass.c | 10 +++++--
src/backend/optimizer/plan/planagg.c | 8 ++++-
src/include/optimizer/paths.h | 3 +-
src/test/regress/expected/aggregates.out | 39 ++++++++++++++++++++++++++++++
src/test/regress/sql/aggregates.sql | 5 ++++
5 files changed, 59 insertions(+), 6 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2012-11-26 20:56:12 pgsql: Revert patch for taking fewer snapshots.
Previous Message Bruce Momjian 2012-11-25 03:39:08 pgsql: In pg_upgrade,simplify function copy_file() by using pg_malloc(