From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | pgsql-committers(at)postgresql(dot)org |
Subject: | pgsql: Back-patch recent fixes for gistchoose and gistRelocateBuildBuff |
Date: | 2012-08-31 03:49:03 |
Message-ID: | E1T7IEB-0006PP-8Y@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Back-patch recent fixes for gistchoose and gistRelocateBuildBuffersOnSplit.
This back-ports commits c8ba697a4bdb934f0c51424c654e8db6133ea255 and
e5db11c5582b469c04a11f217a0f32c827da5dd7, which fix one definite and one
speculative bug in gistchoose, and make the code a lot more intelligible as
well. In 9.2 only, this also affects the largely-copied-and-pasted logic
in gistRelocateBuildBuffersOnSplit.
The impact of the bugs was that the functions might make poor decisions
as to which index tree branch to push a new entry down into, resulting in
GiST index bloat and poor performance. The fixes rectify these decisions
for future insertions, but a REINDEX would be needed to clean up any
existing index bloat.
Alexander Korotkov, Robert Haas, Tom Lane
Branch
------
REL9_0_STABLE
Details
-------
http://git.postgresql.org/pg/commitdiff/1da2a610d7e791e93fcf835855badaeb11196bdd
Modified Files
--------------
src/backend/access/gist/gistutil.c | 98 ++++++++++++++++++++++++++---------
1 files changed, 73 insertions(+), 25 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Heikki Linnakangas | 2012-08-31 08:30:38 | pgsql: Fix typos in README. |
Previous Message | Tom Lane | 2012-08-31 02:53:36 | pgsql: Improve coding of gistchoose and gistRelocateBuildBuffersOnSplit |