pgsql: Fix dumping of security_barrier views with circular dependencies

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Fix dumping of security_barrier views with circular dependencies
Date: 2012-08-21 19:20:59
Message-ID: E1T3u0Z-00071E-63@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-committers

Fix dumping of security_barrier views with circular dependencies.

If a view has circular dependencies, pg_dump splits it into a CREATE TABLE
and a CREATE RULE command to break the dependency loop. However, if the
view has reloptions, those options cannot be applied in the CREATE TABLE
command, because views and tables have different allowed reloptions so
CREATE TABLE would reject them. Instead apply the reloptions after the
CREATE RULE, using ALTER VIEW SET.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/0f524ea0cf388a149f362e48a33c01662eeddc04

Modified Files
--------------
src/bin/pg_dump/pg_dump.c | 25 +++++++++++++++++++++----
src/bin/pg_dump/pg_dump.h | 2 ++
src/bin/pg_dump/pg_dump_sort.c | 13 +++++++++++--
3 files changed, 34 insertions(+), 6 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2012-08-21 22:42:02 pgsql: Avoid somewhat-theoretical overflow risks in RecordIsValid().
Previous Message Robert Haas 2012-08-21 15:48:20 pgsql: Improve C comments in GetSnapshotData.