pgsql: Refactor the way code is shared between some range type function

From: Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Refactor the way code is shared between some range type function
Date: 2012-07-18 20:20:23
Message-ID: E1SrajP-0002OZ-Q8@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Refactor the way code is shared between some range type functions.

Functions like range_eq, range_before etc. are exposed at the SQL-level, but
they're also used internally by the GiST consistent support function. The
code sharing was done by a hack, TrickFunctionCall2, which relied on the
knowledge that all the functions used fn_extra the same way. This commit
splits the functions into internal versions that take a TypeCacheEntry as
argument, and thin wrappers to expose the functions at the SQL-level. The
internal versions can then be called directly and in a less hacky way from
the GiST consistent function.

This is just cosmetic, but backpatch to 9.2 anyway, to avoid having a
different version of this code in the 9.2 branch. That would make
backpatching fixes in this area more difficult.

Alexander Korotkov

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/a7a4add6c4243cbcf50a554bce4c34cb72a344b5

Modified Files
--------------
src/backend/utils/adt/rangetypes.c | 219 ++++++++++++++++++++-----------
src/backend/utils/adt/rangetypes_gist.c | 168 ++++++++----------------
src/include/utils/rangetypes.h | 24 ++++
3 files changed, 220 insertions(+), 191 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2012-07-19 17:07:56 pgsql: Send only one FORGET_RELATION_FSYNC request when dropping a rela
Previous Message Simon Riggs 2012-07-18 20:18:33 Re: pgsql: Fix management of pendingOpsTable in auxiliary processes.