| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> | 
|---|---|
| To: | pgsql-committers(at)postgresql(dot)org | 
| Subject: | pgsql: Fix statistics breakage from bgwriter/checkpointer process split | 
| Date: | 2012-07-18 19:40:48 | 
| Message-ID: | E1Sra76-0001pM-Q0@gemulon.postgresql.org | 
| Views: | Whole Thread | Raw Message | Download mbox | Resend email | 
| Thread: | |
| Lists: | pgsql-committers | 
Fix statistics breakage from bgwriter/checkpointer process split.
ForwardFsyncRequest() supposed that it could only be called in regular
backends, which used to be true; but since the splitup of bgwriter and
checkpointer, it is also called in the bgwriter.  We do not want to count
such calls in pg_stat_bgwriter.buffers_backend statistics, so fix things
so that they aren't.
(It's worth noting here that this implies an alarmingly large increase in
the expected amount of cross-process fsync request traffic, which may well
mean that the process splitup was not such a hot idea.)
Branch
------
master
Details
-------
http://git.postgresql.org/pg/commitdiff/80e373c3a8c43812bdc98fe0d433b9990acce5ad
Modified Files
--------------
src/backend/postmaster/checkpointer.c |    6 ++++--
1 files changed, 4 insertions(+), 2 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Simon Riggs | 2012-07-18 20:18:33 | Re: pgsql: Fix management of pendingOpsTable in auxiliary processes. | 
| Previous Message | Tom Lane | 2012-07-18 19:38:03 | pgsql: Fix management of pendingOpsTable in auxiliary processes. |