pgsql: Fix memory leak in ARRAY(SELECT ...) subqueries.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Fix memory leak in ARRAY(SELECT ...) subqueries.
Date: 2012-06-21 21:27:47
Message-ID: E1Shoup-0000WJ-Ph@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix memory leak in ARRAY(SELECT ...) subqueries.

Repeated execution of an uncorrelated ARRAY_SUBLINK sub-select (which
I think can only happen if the sub-select is embedded in a larger,
correlated subquery) would leak memory for the duration of the query,
due to not reclaiming the array generated in the previous execution.
Per bug #6698 from Armando Miraglia. Diagnosis and fix idea by Heikki,
patch itself by me.

This has been like this all along, so back-patch to all supported versions.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/d14241c2cf72966c09c1acece5cb44b5c84204b4

Modified Files
--------------
src/backend/executor/nodeSubplan.c | 18 +++++++++++++-----
src/include/nodes/execnodes.h | 1 +
2 files changed, 14 insertions(+), 5 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2012-06-21 22:50:41 Re: pgsql: Remove confusing half sentence from legal notice
Previous Message Alvaro Herrera 2012-06-21 19:38:03 pgsql: Repair comment mangled by a pgindent run long ago