pgAdmin III commit: Fix the SQL when adding a new index without a name

From: Guillaume Lelarge <guillaume(at)lelarge(dot)info>
To: pgadmin-hackers(at)postgresql(dot)org
Subject: pgAdmin III commit: Fix the SQL when adding a new index without a name
Date: 2012-04-04 20:52:31
Message-ID: E1SFXBv-00046P-NJ@gothos.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Fix the SQL when adding a new index without a name

When a user adds an index without setting its name, but with a comment or the
CLUSTER option, the two specific SQL commands to set the comment and the
CLUSTER option don't have the name of the index (as we don't know it yet), and
thus fail.

If we don't have a name, we now disable both widgets (comment and cluster),
and we don't take care of their value in GetSql method().

Per report from Bartosz Dmytrak

Branch
------
REL-1_14_0_PATCHES

Details
-------
http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=cb64fefdc5af3ca792690527db60ca7ee2cf4f12

Modified Files
--------------
CHANGELOG | 3 +++
pgadmin/dlg/dlgIndex.cpp | 10 ++++++++--
2 files changed, 11 insertions(+), 2 deletions(-)

Browse pgadmin-hackers by date

  From Date Subject
Next Message Guillaume Lelarge 2012-04-05 21:16:16 pgAdmin III commit: Support for the new two columns in 9.2 pg_stat_data
Previous Message pgAdmin Trac 2012-03-29 19:43:54 Re: [pgAdmin III] #358: Allow to set option is_called for setval (was: Allow to set option is_called for setval Date: Tue, 27 Mar 2012 08:58:32 +0200)