pgsql: Add GetForeignColumnOptions() to foreign.c, and add some documen

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Add GetForeignColumnOptions() to foreign.c, and add some documen
Date: 2012-03-07 23:21:10
Message-ID: E1S5QAQ-0006s9-3G@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Add GetForeignColumnOptions() to foreign.c, and add some documentation.

GetForeignColumnOptions provides some abstraction for accessing
column-specific FDW options, on a par with the access functions that were
already provided here for other FDW-related information.

Adjust file_fdw.c to use GetForeignColumnOptions instead of equivalent
hand-rolled code.

In addition, add some SGML documentation for the functions exported by
foreign.c that are meant for use by FDW authors.

(This is the fdw_helper portion of the proposed pgsql_fdw patch.)

Hanada Shigeru, reviewed by KaiGai Kohei

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/9088d1b96504717fd589ff7eeacc96b6d1c08ead

Modified Files
--------------
contrib/file_fdw/file_fdw.c | 49 +++++--------------
doc/src/sgml/fdwhandler.sgml | 105 +++++++++++++++++++++++++++++++++++++++++
src/backend/foreign/foreign.c | 37 ++++++++++++++-
src/include/foreign/foreign.h | 2 +
4 files changed, 154 insertions(+), 39 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2012-03-08 00:26:07 pgsql: Fix indentation of \d footers for non-ASCII cases.
Previous Message Robert Haas 2012-03-07 22:20:07 pgsql: Attempt to reduce locale dependencies in regression tests.