pgsql: Convert newlines to spaces in names written in pg_dump comments.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Convert newlines to spaces in names written in pg_dump comments.
Date: 2012-02-23 23:04:47
Message-ID: E1S0hiR-00088o-1w@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Convert newlines to spaces in names written in pg_dump comments.

pg_dump was incautious about sanitizing object names that are emitted
within SQL comments in its output script. A name containing a newline
would at least render the script syntactically incorrect. Maliciously
crafted object names could present a SQL injection risk when the script
is reloaded.

Reported by Heikki Linnakangas, patch by Robert Haas

Security: CVE-2012-0868

Branch
------
REL8_3_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/a7f6cb85486b1f3eacd86155af2fdc20a1dc2bec

Modified Files
--------------
src/bin/pg_dump/pg_backup_archiver.c | 60 +++++++++++++++++++++++++++++++--
1 files changed, 56 insertions(+), 4 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Andrew Dunstan 2012-02-24 04:45:20 pgsql: Correctly handle NULLs in JSON output.
Previous Message Tom Lane 2012-02-23 23:04:46 pgsql: Require execute permission on the trigger function for CREATE TR