From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | pgsql-committers(at)postgresql(dot)org |
Subject: | pgsql: Fix up dumping conditions for extension configuration tables. |
Date: | 2012-02-08 20:23:06 |
Message-ID: | E1RvE2k-0008P9-Pf@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Fix up dumping conditions for extension configuration tables.
Various filters that were meant to prevent dumping of table data were not
being applied to extension config tables, notably --exclude-table-data and
--no-unlogged-table-data. We also would bogusly try to dump data from
views, sequences, or foreign tables, should an extension try to claim they
were config tables. Fix all that, and refactor/redocument to try to make
this a bit less fragile. This reverts the implementation, though not the
feature, of commit 7b070e896ca835318c90b02c830a5c4844413b64, which had
broken config-table dumping altogether :-(.
It is still the case that the code will dump config-table data even if
--schema is specified. That behavior was intentional, as per the comments
in getExtensionMembership, so I think it requires some more discussion
before we change it.
Branch
------
master
Details
-------
http://git.postgresql.org/pg/commitdiff/d77354eaec53ed469a6f2444813ff3a4fd9d7a48
Modified Files
--------------
src/bin/pg_dump/pg_dump.c | 77 ++++++++++++++++++++++++--------------------
src/bin/pg_dump/pg_dump.h | 1 -
2 files changed, 42 insertions(+), 36 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2012-02-08 21:19:39 | pgsql: Throw error sooner for unlogged GiST indexes. |
Previous Message | Tom Lane | 2012-02-08 18:15:18 | pgsql: Check misplaced window functions before checking aggregate/group |