pgsql: pg_dump: Further reduce reliance on global variables.

From: Robert Haas <rhaas(at)postgresql(dot)org>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: pg_dump: Further reduce reliance on global variables.
Date: 2012-02-07 15:07:24
Message-ID: E1Rumdg-0007lM-Ax@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

pg_dump: Further reduce reliance on global variables.

This is another round of refactoring to make things simpler for parallel
pg_dump. pg_dump.c now issues SQL queries through the relevant Archive
object, rather than relying on the global variable g_conn. This commit
isn't quite enough to get rid of g_conn entirely, but it makes a big
dent in its utilization and, along the way, manages to be slightly less
code than before.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/1631598ea204a3b05104f25d008b510ff5a5c94a

Modified Files
--------------
src/bin/pg_dump/pg_backup_archiver.c | 10 +
src/bin/pg_dump/pg_backup_archiver.h | 1 +
src/bin/pg_dump/pg_backup_db.c | 24 ++
src/bin/pg_dump/pg_backup_db.h | 4 +
src/bin/pg_dump/pg_dump.c | 449 ++++++++++++++--------------------
5 files changed, 218 insertions(+), 270 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2012-02-07 16:29:48 pgsql: Add TIMING option to EXPLAIN, to allow eliminating of timing ove
Previous Message Peter Eisentraut 2012-02-07 12:58:03 pgsql: createuser: Disable prompting by default