From: | Robert Haas <rhaas(at)postgresql(dot)org> |
---|---|
To: | pgsql-committers(at)postgresql(dot)org |
Subject: | pgsql: Improve behavior of concurrent CLUSTER. |
Date: | 2011-12-21 20:22:15 |
Message-ID: | E1RdSg3-0002DM-En@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Improve behavior of concurrent CLUSTER.
In the previous coding, a user could queue up for an AccessExclusiveLock
on a table they did not have permission to cluster, thus potentially
interfering with access by authorized users who got stuck waiting behind
the AccessExclusiveLock. This approach avoids that. cluster() has the
same permissions-checking requirements as REINDEX TABLE, so this commit
moves the now-shared callback to tablecmds.c and renames it, per
discussion with Noah Misch.
Branch
------
master
Details
-------
http://git.postgresql.org/pg/commitdiff/cbe24a6dd8fb224b9585f25b882d5ffdb55a0ba5
Modified Files
--------------
src/backend/commands/cluster.c | 16 +++++++---------
src/backend/commands/indexcmds.c | 36 ++----------------------------------
src/backend/commands/tablecmds.c | 35 +++++++++++++++++++++++++++++++++++
src/include/commands/tablecmds.h | 3 +++
4 files changed, 47 insertions(+), 43 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2011-12-21 23:23:53 | pgsql: Update per-column ACLs, not only per-table ACL, when changing ta |
Previous Message | Robert Haas | 2011-12-21 14:22:28 | pgsql: Take fewer snapshots. |