| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | pgsql-committers(at)postgresql(dot)org |
| Subject: | pgsql: Remove user-selectable ANALYZE option for range types. |
| Date: | 2011-11-23 05:03:38 |
| Message-ID: | E1RT4zi-0005rL-AN@gemulon.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Remove user-selectable ANALYZE option for range types.
It's not clear that a per-datatype typanalyze function would be any more
useful than a generic typanalyze for ranges. What *is* clear is that
letting unprivileged users select typanalyze functions is a crash risk or
worse. So remove the option from CREATE TYPE AS RANGE, and instead put in
a generic typanalyze function for ranges. The generic function does
nothing as yet, but hopefully we'll improve that before 9.2 release.
Branch
------
master
Details
-------
http://git.postgresql.org/pg/commitdiff/74c1723fc8dca2d70576ef2f0a66f4a7c99c173a
Modified Files
--------------
doc/src/sgml/ref/create_type.sgml | 7 -------
src/backend/commands/typecmds.c | 18 +-----------------
src/backend/utils/adt/rangetypes.c | 17 +++++++++++++++++
src/bin/pg_dump/pg_dump.c | 14 +++++---------
src/include/catalog/catversion.h | 2 +-
src/include/catalog/pg_proc.h | 3 +++
src/include/catalog/pg_type.h | 12 ++++++------
src/include/utils/rangetypes.h | 3 +++
8 files changed, 36 insertions(+), 40 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2011-11-23 17:46:03 | pgsql: Creator of a range type must have permission to call support fun |
| Previous Message | Tom Lane | 2011-11-23 01:45:21 | pgsql: Remove zero- and one-argument range constructor functions. |