pgsql: Remove the custom_variable_classes parameter.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Remove the custom_variable_classes parameter.
Date: 2011-10-04 16:37:28
Message-ID: E1RB7zk-0007GT-Mz@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Remove the custom_variable_classes parameter.

This variable provides only marginal error-prevention capability (since
it can only check the prefix of a qualified GUC name), and the consensus
is that that isn't worth the amount of hassle that maintaining the setting
creates for DBAs. So, let's just remove it.

With this commit, the system will silently accept a value for any qualified
GUC name at all, whether it has anything to do with any known extension or
not. (Unqualified names still have to match known built-in settings,
though; and you will get a WARNING at extension load time if there's an
unrecognized setting with that extension's prefix.)

There's still some discussion ongoing about whether to tighten that up and
if so how; but if we do come up with a solution, it's not likely to look
anything like custom_variable_classes.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/1a00c0ef5368bb7b8ddcb3cf279df36577918ac4

Modified Files
--------------
doc/src/sgml/auth-delay.sgml | 6 +-
doc/src/sgml/auto-explain.sgml | 6 +-
doc/src/sgml/config.sgml | 57 ++-------
doc/src/sgml/pgstatstatements.sgml | 7 +-
doc/src/sgml/plperl.sgml | 4 -
doc/src/sgml/plpgsql.sgml | 7 +-
src/backend/utils/misc/guc-file.l | 114 ++----------------
src/backend/utils/misc/guc.c | 159 ++-----------------------
src/backend/utils/misc/postgresql.conf.sample | 2 +-
src/pl/plperl/expected/plperl_init.out | 2 +-
src/pl/plperl/expected/plperl_shared.out | 2 +-
src/pl/plperl/expected/plperlu.out | 2 +-
src/pl/plperl/sql/plperl_init.sql | 2 +-
src/pl/plperl/sql/plperl_shared.sql | 2 +-
src/pl/plperl/sql/plperlu.sql | 2 +-
15 files changed, 51 insertions(+), 323 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Alvaro Herrera 2011-10-04 17:10:55 pgsql: Use callbacks in SlruScanDirectory for the actual action
Previous Message Amit Khandekar 2011-10-04 09:09:44 Re: Re: [COMMITTERS] pgsql: Force strings passed to and from plperl to be in UTF8 encoding.