From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | pgsql-committers(at)postgresql(dot)org |
Subject: | pgsql: Fix get_name_for_var_field() to deal with RECORD Params. |
Date: | 2011-09-07 17:02:52 |
Message-ID: | E1R1LWW-0004dD-IO@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Fix get_name_for_var_field() to deal with RECORD Params.
With 9.1's use of Params to pass down values from NestLoop join nodes
to their inner plans, it is possible for a Param to have type RECORD, in
which case the set of fields comprising the value isn't determinable by
inspection of the Param alone. However, just as with a Var of type RECORD,
we can find out what we need to know if we can locate the expression that
the Param represents. We already knew how to do this in get_parameter(),
but I'd overlooked the need to be able to cope in get_name_for_var_field(),
which led to EXPLAIN failing with "record type has not been registered".
To fix, refactor the search code in get_parameter() so it can be used by
both functions.
Per report from Marti Raudsepp.
Branch
------
REL9_1_STABLE
Details
-------
http://git.postgresql.org/pg/commitdiff/90398132417232cb56dcda53a4cb66ed2d579681
Modified Files
--------------
src/backend/utils/adt/ruleutils.c | 171 +++++++++++++++++++++++++------------
1 files changed, 115 insertions(+), 56 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2011-09-07 17:29:48 | pgsql: Fix typo in error message. |
Previous Message | Bruce Momjian | 2011-09-07 16:59:53 | pgsql: Have pgrminclude skip files that use CppAsString2 because CppAsS |