From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | pgsql-committers(at)postgresql(dot)org |
Subject: | pgsql: Fix pgxs.mk to always add --dbname=$(CONTRIB_TESTDB) to REGRESS |
Date: | 2011-08-24 19:17:12 |
Message-ID: | E1QwIwq-0004FT-CZ@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Fix pgxs.mk to always add --dbname=$(CONTRIB_TESTDB) to REGRESS_OPTS.
The previous coding resulted in contrib modules unintentionally overriding
the use of CONTRIB_TESTDB. There seems no particularly good reason to
allow that (after all, the makefile can set CONTRIB_TESTDB if that's really
what it intends).
In passing, document REGRESS_OPTS where the other pgxs.mk options are
documented.
Back-patch to 9.1 --- in prior versions, there were no cases of contrib
modules setting REGRESS_OPTS without including the --dbname switch, so
while the coding was fragile there was no actual bug.
Branch
------
master
Details
-------
http://git.postgresql.org/pg/commitdiff/d1d388603e4f9233d3e01847405b239972a54fdf
Modified Files
--------------
contrib/sepgsql/Makefile | 4 +++-
doc/src/sgml/extend.sgml | 9 +++++++++
src/makefiles/pgxs.mk | 7 +++----
3 files changed, 15 insertions(+), 5 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Alvaro Herrera | 2011-08-24 21:35:15 | pgsql: Update FK alternative test output to new whitespace rules |
Previous Message | Peter Eisentraut | 2011-08-24 18:43:56 | pgsql: Build src/ before contrib/ in make world |