pgsql: Make CREATE EXTENSION check schema creation permissions.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Make CREATE EXTENSION check schema creation permissions.
Date: 2011-08-24 01:49:46
Message-ID: E1Qw2bC-0005nA-0N@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Make CREATE EXTENSION check schema creation permissions.

When creating a new schema for a non-relocatable extension, we neglected
to check whether the calling user has permission to create schemas.
That didn't matter in the original coding, since we had already checked
superuserness, but in the new dispensation where users need not be
superusers, we should check it. Use CreateSchemaCommand() rather than
calling NamespaceCreate() directly, so that we also enforce the rules
about reserved schema names.

Per complaint from KaiGai Kohei, though this isn't the same as his patch.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/d4aa491493e6cfa7542d16deba4018c2fd7af9fd

Modified Files
--------------
src/backend/commands/extension.c | 16 +++++++++++++---
1 files changed, 13 insertions(+), 3 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2011-08-24 17:09:34 pgsql: Fix multiple bugs in extension dropping.
Previous Message Tom Lane 2011-08-24 01:49:45 pgsql: Make CREATE EXTENSION check schema creation permissions.