pgAdmin III commit: Current behaviour of the ExplainPopup, requires a m

From: Dave Page <dpage(at)pgadmin(dot)org>
To: pgadmin-hackers(at)postgresql(dot)org
Subject: pgAdmin III commit: Current behaviour of the ExplainPopup, requires a m
Date: 2011-07-11 14:27:14
Message-ID: E1QgHS6-0001Ab-4y@gothos.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Current behaviour of the ExplainPopup, requires a mouse click on the ExplainShape to show it.
A lot of user will not able to figure out that until they accidentally click on that shape or
read the documents carefully.

Also - current implementation does not allow to use the ExplainCanvas in a modal dialog.
For some experiment, I tried to use the ExplainCanvas in a modal dialog and clicked on a shape.

A lot of time on linux, this scenario resulted in a crash or unstable pgadmin application.

The attached patch enables the ExplainPopup to behave like the tooltip for those shapes.
As per my conversation with Dave, I have extended the ExplainPopup using wxTransientPopup or, wxFrame
(where not available wxPopWindow i.e. Mac), just like the wxTipWindow, and also worked on the border
around the ExplainText.

Branch
------
master

Details
-------
http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=659c13f32483a64bdbde241eb0db56696e29f800
Author: Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>

Modified Files
--------------
pgadmin/ctl/explainCanvas.cpp | 305 ++++++++++++++++++++++++++++++-----
pgadmin/include/ctl/explainCanvas.h | 47 +++++-
2 files changed, 307 insertions(+), 45 deletions(-)

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2011-07-11 14:27:44 Re: Graphical Explain Tooltip
Previous Message Guillaume Lelarge 2011-07-11 14:21:57 Re: Overhaul of type attributes modification