pgsql: Expose the "*VALUES*" alias that we generate for a stand-alone V

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Expose the "*VALUES*" alias that we generate for a stand-alone V
Date: 2011-06-04 19:49:10
Message-ID: E1QSwqM-0005tx-P8@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Expose the "*VALUES*" alias that we generate for a stand-alone VALUES list.

We were trying to make that strictly an internal implementation detail,
but it turns out that it's exposed anyway when dumping a view defined
like
CREATE VIEW test_view AS VALUES (1), (2), (3) ORDER BY 1;
This comes out as
CREATE VIEW ... ORDER BY "*VALUES*".column1;
which fails to parse when reloading the dump.

Hacking ruleutils.c to suppress the column qualification looks like it'd
be a risky business, so instead promote the RTE alias to full-fledged
usability.

Per bug #6049 from Dylan Adams. Back-patch to all supported branches.

Branch
------
REL8_4_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/1c2af01b98c3aece7e5f6978137effcf06e8b81d

Modified Files
--------------
src/backend/parser/analyze.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2011-06-04 19:54:12 pgsql: ECPG documentation fix
Previous Message Tatsuo Ishii 2011-06-03 22:58:50 Re: [COMMITTERS] pgsql: Disallow SELECT FOR UPDATE/SHARE on sequences.