pgsql: Make plpgsql complain about conflicting IN and OUT parameter nam

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Make plpgsql complain about conflicting IN and OUT parameter nam
Date: 2011-05-23 20:35:32
Message-ID: E1QObqe-0005cV-Ct@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Make plpgsql complain about conflicting IN and OUT parameter names.

The core CREATE FUNCTION code only enforces that IN parameter names are
non-duplicate, and that OUT parameter names are separately non-duplicate.
This is because some function languages might not have any confusion
between the two. But in plpgsql, such names are all in the same namespace,
so we'd better disallow it.

Per a recent complaint from Dan S. Not back-patching since this is a small
issue and the change could cause unexpected failures if we started to
enforce it in a minor release.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/59a4a571d396ec00a7e363dca8b2f5eb2d8307ad

Modified Files
--------------
src/pl/plpgsql/src/pl_comp.c | 30 ++++++++++++++++++++++++++++--
1 files changed, 28 insertions(+), 2 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Hitoshi Harada 2011-05-24 09:59:22 Re: pgsql: Support RIGHT and FULL OUTER JOIN in hash joins.
Previous Message Heikki Linnakangas 2011-05-23 19:30:23 pgsql: Fix integer overflow in text_format function, reported by Dean R