From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | pgsql-committers(at)postgresql(dot)org |
Subject: | pgsql: Rewrite pg_size_pretty() to avoid compiler bug. |
Date: | 2011-04-29 05:46:09 |
Message-ID: | E1QFgWn-0002OE-Fg@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Rewrite pg_size_pretty() to avoid compiler bug.
Convert it to use successive shifts right instead of increasing a divisor.
This is probably a tad more efficient than the original coding, and it's
nicer-looking than the previous patch because we don't need a special case
to avoid overflow in the last branch. But the real reason to do it is to
avoid a Solaris compiler bug, as per results from buildfarm member moa.
Branch
------
REL8_4_STABLE
Details
-------
http://git.postgresql.org/pg/commitdiff/c5459735fd4d5ec8ea5ebfcd5dec03548d9ac8d4
Modified Files
--------------
src/backend/utils/adt/dbsize.c | 32 +++++++++++++-------------------
1 files changed, 13 insertions(+), 19 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2011-04-29 20:30:32 | pgsql: Remove special case for xmin == xmax in HeapTupleSatisfiesVacuum |
Previous Message | User Itagaki | 2011-04-29 05:06:49 | reorg - pg_reorg: Fixed database corruption when target tables have |