pgsql: Fix pg_size_pretty() to avoid overflow for inputs close to INT64

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Fix pg_size_pretty() to avoid overflow for inputs close to INT64
Date: 2011-04-25 20:22:41
Message-ID: E1QESIr-0002uh-BA@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Fix pg_size_pretty() to avoid overflow for inputs close to INT64_MAX.

The expression that tried to round the value to the nearest TB could
overflow, leading to bogus output as reported in bug #5993 from Nicola
Cossu. This isn't likely to ever happen in the intended usage of the
function (if it could, we'd be needing to use a wider datatype instead);
but it's not hard to give the expected output, so let's do so.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/af0f20092c8662bf7610fab07b8a1e354abba67f

Modified Files
--------------
src/backend/utils/adt/dbsize.c | 8 +++++++-
1 files changed, 7 insertions(+), 1 deletions(-)

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2011-04-25 20:41:19 pgsql: Remove partial and undocumented GRANT .. FOREIGN TABLE support.
Previous Message Peter Eisentraut 2011-04-25 19:28:31 pgsql: Support "make check" in contrib

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2011-04-25 20:28:56 Re: branching for 9.2devel
Previous Message Daniel Farina 2011-04-25 20:21:57 Re: fsync reliability