pgsql: Revert addition of third argument to format_type().

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Revert addition of third argument to format_type().
Date: 2011-03-10 22:31:09
Message-ID: E1PxoNx-00080e-EX@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Revert addition of third argument to format_type().

Including collation in the behavior of that function promotes a world view
we do not want. Moreover, it was producing the wrong behavior for pg_dump
anyway: what we want is to dump a COLLATE clause on attributes whose
attcollation is different from the underlying type, and likewise for
domains, and the function cannot do that for us. Doing it the hard way
in pg_dump is a bit more tedious but produces more correct output.

In passing, fix initdb so that the initial entry in pg_collation is
properly pinned. It was droppable before :-(

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/7564654adf07ec26b83c7effc7f54f7183e04519

Modified Files
--------------
doc/src/sgml/func.sgml | 6 +--
src/backend/catalog/system_views.sql | 4 --
src/backend/utils/adt/format_type.c | 25 +++--------
src/bin/initdb/initdb.c | 2 +
src/bin/pg_dump/common.c | 15 ++++++-
src/bin/pg_dump/pg_dump.c | 75 ++++++++++++++++++++++++++++------
src/bin/pg_dump/pg_dump.h | 2 +
src/include/catalog/catversion.h | 2 +-
src/include/catalog/pg_proc.h | 4 +-
9 files changed, 92 insertions(+), 43 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Bruce Momjian 2011-03-10 23:10:31 pgsql: Add proper git-external-diff script to src/tools.
Previous Message Robert Haas 2011-03-10 21:28:12 Re: [COMMITTERS] pgsql: Efficient transaction-controlled synchronous replication.