pgsql: Improve pg_upgrade's checks for required executables.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Improve pg_upgrade's checks for required executables.
Date: 2010-12-29 18:44:14
Message-ID: E1PY10Q-0005I4-3i@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Improve pg_upgrade's checks for required executables.

Don't insist on pg_dumpall and psql being present in the old cluster,
since they are not needed. Do insist on pg_resetxlog being present
(in both old and new), since we need it. Also check for pg_config,
but only in the new cluster. Remove the useless attempt to call
pg_config in the old cluster; we don't need to know the old value of
--pkglibdir. (In the case of a stripped-down migration installation
there might be nothing there to look at anyway, so any future change
that might reintroduce that need would have to be considered carefully.)

Per my attempts to build a minimal previous-version installation to support
pg_upgrade.

Branch
------
master

Details
-------
http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=88c803457a53d2f83168519f0651e6dc258003b5

Modified Files
--------------
contrib/pg_upgrade/exec.c | 18 ++++++++++++------
contrib/pg_upgrade/option.c | 6 +++++-
2 files changed, 17 insertions(+), 7 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Bruce Momjian 2010-12-29 18:50:00 pgsql: Doc wording improvement: taken -> accepted
Previous Message Magnus Hagander 2010-12-29 12:41:32 Re: pgsql: Add REPLICATION privilege for ROLEs