pgsql: Save a few cycles in plpgsql simple-expression initialization.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Save a few cycles in plpgsql simple-expression initialization.
Date: 2010-10-28 17:29:32
Message-ID: E1PBWI8-0008HF-Ez@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Save a few cycles in plpgsql simple-expression initialization.

Instead of using ExecPrepareExpr, call ExecInitExpr. The net change here
is that we don't apply expression_planner() to the expression tree. There
is no need to do so, because that tree is extracted from a fully planned
plancache entry, so all the needed work is already done. This reduces
the setup costs by about a factor of 2 according to some simple tests.
Oversight noted while fooling around with the simple-expression code for
previous fix.

Branch
------
master

Details
-------
http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=37e0a016547abb3526b685d7aacbd0a4d57f6937

Modified Files
--------------
src/pl/plpgsql/src/pl_exec.c | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2010-10-28 20:07:44 pgsql: Add tab completion for psql \dg and \z
Previous Message Tom Lane 2010-10-28 17:03:55 pgsql: Fix plpgsql's handling of "simple" expression evaluation.