pgsql: Don't try to fetch database name when SetTransactionIdLimit() is

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Don't try to fetch database name when SetTransactionIdLimit() is
Date: 2010-10-20 16:49:55
Message-ID: E1P8brO-0007aX-WC@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Don't try to fetch database name when SetTransactionIdLimit() is executed
outside a transaction.

This repairs brain fade in my patch of 2009-08-30: the reason we had been
storing oldest-database name, not OID, in ShmemVariableCache was of course
to avoid having to do a catalog lookup at times when it might be unsafe.

This error explains why Aleksandr Dushein is having trouble getting out of
an XID wraparound state in bug #5718, though not how he got into that state
in the first place. I suspect pg_upgrade is at fault there.

Branch
------
master

Details
-------
http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=def30e84c41389225ee9e56cb7c722980bab9746

Modified Files
--------------
src/backend/access/transam/varsup.c | 18 ++++++++++++++----
1 files changed, 14 insertions(+), 4 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Heikki Linnakangas 2010-10-20 19:33:35 pgsql: If pk is NULL, the backend would segfault when accessing ->algo
Previous Message Alvaro Herrera 2010-10-20 14:59:23 pgsql: Remove AtStart_Cache() call in CommandCounterIncrement().